Skip to content

fix: APAC region documentation and test expectations #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2025
Merged

fix: APAC region documentation and test expectations #240

merged 2 commits into from
Oct 3, 2025

Conversation

@pru55e11
Copy link
Contributor

@pru55e11 pru55e11 commented Oct 3, 2025 •
edited by shazron
Loading

Description

This is a doc update for apac support.
apac has been supported since v5.1.0: https://github.com/adobe/aio-lib-state/releases/tag/5.1.0

Related Issue

ACNA-4089

Motivation and Context

So users can select apac!

How Has This Been Tested?

jest

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@shazron shazron changed the title Fix APAC region documentation and test expectations fix: APAC region documentation and test expectations Oct 3, 2025
@shazron
fix: make the error message match exactly
6d528a7 
the previous way was a substring match
shazron
shazron approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added 6d528a7

@shazron shazron merged commit fbcf3c2 into main Oct 3, 2025
9 checks passed
@shazron shazron deleted the fix-apac-region-support branch October 3, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shazron shazron shazron approved these changes

@moritzraho moritzraho moritzraho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pru55e11 @shazron @moritzraho